hotfix: don't early exit with error if root is not a git dir #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This broke reporting workflow in a case where artifact was being reported from a docker container. Previously, Fetching head manually was done in the end, after checking all env variables. In the last change, we were still doing an early exit when the git rev parse command threw an error, not allowing the flow to reach till extracting git commit from env variable set in docker container. This change restores the previous workflow.
sourya-deepsource
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke reporting workflow in a case where an artifact was being reported from a docker container. Previously, Fetching HEAD manually was done in the end, after checking all env variables. In the last change, we were doing an early exit when the
git rev-parsecommand threw an error, not allowing the flow to reach extracting git commit from env variable set in the docker container.This change restores the previous workflow.