chore: check supported keys only for test-coverage #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srijan-deepsource
requested a review
from sourya-deepsource
as a code owner
| @@ -127,7 +127,7 @@ func (opts *ReportOptions) Run() int { | |||
| return keys | |||
| } | |||
|
|
|||
| if !supportedKeys[reportCommandKey] { | |||
| if reportCommandAnalyzerShortcode == "test-coverage" && !supportedKeys[reportCommandKey] { | |||
There was a problem hiding this comment.
Does the logic following this if block make sense if the analyzer is not test-coverage?
There was a problem hiding this comment.
The logic in the if block makes sense only for test-coverage analyzer. key was designed to be an optional field, and only test coverage analyzer accepts artifacts with multiple keys.
Everything else after this if block makes sense for all analyzers.
sourya-deepsource
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keyis an optional flag, and is only used by the test coverage analyzer to identify the language for the report.Previously, the check would always fail since it was matching against a whitelist of supported keys. This PR changes the behavior to check it only for test-coverage artifact reporting.