fix(utils): add support for PAT based remote URLs #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Before we proceed, you"ll need to sign a Contributor License Agreement - https://docs.google.com/document/d/1Wj255zTFkO0XpC7piChAa0yd96KCEqXf4Qa3e87F5UA. Please send the signed copy to jai@deepsource.io to proceed with the patch review. |
* add regular expressions to extract owner from remote URL * fix typos Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
There was a problem hiding this comment.
@burntcarrot Good catch and thanks for the patch. Would be great if you can add tests. 🚀
* add mocks for commands * add test for fetching remotes * refactor remote fetching utility to adjust mocks * refactor remote resolver Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
* refactor ListRemotes * refactor tests * add new test cases for SSH and multiple remotes * move to field-based splitting instead of tab-based splitting Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
siddhant-deepsource
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current method of extracting owners from remote URLs doesn't work with remote URLs having a PAT in it, for example:
https://username:<access_token>@github.com/username/repoThis can be improved by using a regular expression like this, which can extract owner names from both type of remote URLs, as shown here.
Signed-off-by: burntcarrot aadhav.n1@gmail.com