Fix argcompletion shell code generation #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression introduced by c37cd68, which bumped argcompletion, which included an undocumented breaking change (kislyuk/argcomplete#246) that lead to generating `d m a k e` instead of `dmake` in the final bash script, breaking the completion (and maybe other things).
maingoh
approved these changes
Jan 25, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression introduced by c37cd68,
which bumped argcompletion, which included an undocumented breaking
change (kislyuk/argcomplete#246) that lead to
generating
d m a k einstead ofdmakein the final bash script,breaking the completion (and maybe other things).
How to fix the installation on your machine
(run from a directory containing a dmake project to avoid
Current directory is not a Git repositoryerror):(see
dmake completion --helpfor other shells than bash)