Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finding Template: Correct save ordering #9088

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Finding Template: Correct save ordering #9088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dojo/finding/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# # findings

Check warning on line 1 in dojo/finding/views.py

View check run for this annotation

DryRunSecurity / AI-powered Sensitive Files Check

Possible Sensitive File 


                    Our AI-Powered Sensitive File checker believes it has discovered
                    a sensitive file being modified in this PR. Extra care must be taken
                    when modifying a file that is potentially security-sensitive.
                    
                    The following reason was provided: Contains code related to finding and disclosing vulnerabilities. It may contain sensitive information such as security vulnerabilities and their remediation steps.
import base64
import json
import logging
Expand Down Expand Up @@ -2303,10 +2303,10 @@
template.numerical_severity = Finding.get_numerical_severity(
template.severity
)
template.save()
finding_helper.save_vulnerability_ids_template(
template, form.cleaned_data["vulnerability_ids"].split()
)
template.save()
form.save_m2m()
count = apply_cwe_mitigation(
form.cleaned_data["apply_to_findings"], template
Expand Down