Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@storybook/addon-knobs: add button() knob #23302

Merged
merged 1 commit into from
Jan 31, 2018

Conversation

gustavohenke
Copy link
Contributor

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

This knob was introduced by storybookjs/storybook#2004 in v3.2.13 of Storybook.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 31, 2018

@gustavohenke Thank you for submitting this PR!

🔔 @joscha @martynaskadisa - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

If no reviewer appears after a week, a DefinitelyTyped maintainer will review the PR instead.

Copy link
Contributor

@joscha joscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we bump the types version to the minor that contains the new button element?

@typescript-bot
Copy link
Contributor

A definition author has approved this PR ⭐️. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait. Thank you for your contribution to DefinitelyTyped!

@gustavohenke
Copy link
Contributor Author

should we bump the types version to the minor that contains the new button element?

I didn't read the rest of the changelog from v3.2.1 to v3.2.13 to see if other meaningful changes were introduced though!

@joscha
Copy link
Contributor

joscha commented Jan 31, 2018

I didn't read the rest of the changelog from v3.2.1 to v3.2.13 to see if other meaningful changes were introduced though!

well this is only the knobs portion, so it should be okay.

@sheetalkamat sheetalkamat merged commit 99614fa into DefinitelyTyped:master Jan 31, 2018
@gustavohenke gustavohenke deleted the addon-knobs branch January 31, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants