-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dont list Cypress as a dependency for @testing-library/cypress
#44962
Conversation
@kylemh Thank you for submitting this PR! Code ReviewsBecause this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 44962,
"author": "kylemh",
"owners": [
"aaronmcadam",
"bastibuck",
"NoriSte",
"wKovacs64",
"existentialism",
"airato",
"simjes"
],
"dangerLevel": "ScopedAndConfiguration",
"headCommitAbbrOid": "ce77d8a",
"headCommitOid": "ce77d8a3b5468359b1cdbc313f26db34b2079c58",
"mergeIsRequested": false,
"stalenessInDays": 0,
"lastCommitDate": "2020-05-21T18:26:02.000Z",
"lastCommentDate": "2020-05-21T18:26:02.000Z",
"reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44962/files",
"hasMergeConflict": false,
"authorIsOwner": false,
"isFirstContribution": false,
"popularityLevel": "Popular",
"anyPackageIsNew": false,
"packages": [
"testing-library__cypress"
],
"files": [
{
"filePath": "types/testing-library__cypress/package.json",
"kind": "package-meta",
"package": "testing-library__cypress"
}
],
"hasDismissedReview": false,
"travisResult": "fail",
"travisUrl": "https://travis-ci.org/github/DefinitelyTyped/DefinitelyTyped/builds/689751416?utm_source=github_status&utm_medium=notification",
"reviewersWithStaleReviews": [],
"approvalFlags": 0,
"isChangesRequested": false
} |
🔔 @aaronmcadam @bastibuck @NoriSte @wKovacs64 @existentialism @airato @simjes - please review this PR in the next few days. Be sure to explicitly select |
👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings. Let’s review the numbers, shall we? Comparison details 📊
It looks like nothing changed too much. I won’t post performance data again unless it gets worse. |
Due to a design limitation in DefinitelyTyped, it doesn't support `peerDependencies`. This means that Synpress, even when used with Playwright, transitively depends on Cypress, and installs it for its users. PRs that try to fix it get closed: - DefinitelyTyped/DefinitelyTyped#67000 (review) - DefinitelyTyped/DefinitelyTyped#44962 I moved `@types/testing-library__cypress` to `peerDependencies`.
Due to a design limitation in DefinitelyTyped, it doesn't support `peerDependencies`. This means that Synpress, even when used with Playwright, transitively depends on Cypress, and installs it for its users. PRs that try to fix it get closed: - DefinitelyTyped/DefinitelyTyped#67000 (review) - DefinitelyTyped/DefinitelyTyped#44962 I moved `@types/testing-library__cypress` to `peerDependencies`.
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).