Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont list Cypress as a dependency for @testing-library/cypress #44962

Closed
wants to merge 2 commits into from
Closed

Conversation

kylemh
Copy link
Contributor

@kylemh kylemh commented May 21, 2020

Please fill in this template.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code. (Compile and run.)
  • Add or edit tests to reflect the change. (Run with npm test.)
  • Follow the advice from the readme.
  • Avoid common mistakes.
  • Run npm run lint package-name (or tsc if no tslint.json is present).

@typescript-bot
Copy link
Contributor

typescript-bot commented May 21, 2020

@kylemh Thank you for submitting this PR!

Code Reviews

Because this PR edits the configuration file, it can be merged once it's reviewed by a DT maintainer.

Status

  • ✅ No merge conflicts
  • ❌ Continuous integration tests have passed
  • ❌ A DT maintainer needs to merge changes which affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 44962,
  "author": "kylemh",
  "owners": [
    "aaronmcadam",
    "bastibuck",
    "NoriSte",
    "wKovacs64",
    "existentialism",
    "airato",
    "simjes"
  ],
  "dangerLevel": "ScopedAndConfiguration",
  "headCommitAbbrOid": "ce77d8a",
  "headCommitOid": "ce77d8a3b5468359b1cdbc313f26db34b2079c58",
  "mergeIsRequested": false,
  "stalenessInDays": 0,
  "lastCommitDate": "2020-05-21T18:26:02.000Z",
  "lastCommentDate": "2020-05-21T18:26:02.000Z",
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/44962/files",
  "hasMergeConflict": false,
  "authorIsOwner": false,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "anyPackageIsNew": false,
  "packages": [
    "testing-library__cypress"
  ],
  "files": [
    {
      "filePath": "types/testing-library__cypress/package.json",
      "kind": "package-meta",
      "package": "testing-library__cypress"
    }
  ],
  "hasDismissedReview": false,
  "travisResult": "fail",
  "travisUrl": "https://travis-ci.org/github/DefinitelyTyped/DefinitelyTyped/builds/689751416?utm_source=github_status&utm_medium=notification",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 0,
  "isChangesRequested": false
}

@typescript-bot
Copy link
Contributor

🔔 @aaronmcadam @bastibuck @NoriSte @wKovacs64 @existentialism @airato @simjes - please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added The Travis CI build failed Popular package This PR affects a popular package (as counted by NPM download counts). labels May 21, 2020
@typescript-bot
Copy link
Contributor

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊
master #44962 diff
Batch compilation
Memory usage (MiB) 134.8 133.9 -0.7%
Type count 35383 35383 0%
Assignability cache size 39360 39360 0%
Language service
Samples taken 81 81 0%
Identifiers in tests 81 81 0%
getCompletionsAtPosition
    Mean duration (ms) 326.9 332.7 +1.8%
    Mean CV 15.4% 16.7%
    Worst duration (ms) 576.4 561.4 -2.6%
    Worst identifier findByPlaceholderText findAllByPlaceholderText
getQuickInfoAtPosition
    Mean duration (ms) 319.6 319.4 -0.1%
    Mean CV 16.6% 15.1% -9.0%
    Worst duration (ms) 607.0 494.9 -18.5%
    Worst identifier cy findAllByText

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

@typescript-bot typescript-bot added the Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. label May 21, 2020
@kylemh kylemh closed this May 21, 2020
@kylemh kylemh deleted the patch-3 branch May 21, 2020 18:42
hasparus added a commit to hasparus/synpress that referenced this pull request Feb 7, 2024
Due to a design limitation in DefinitelyTyped, it doesn't support
`peerDependencies`. This means that Synpress, even when used with
Playwright, transitively depends on Cypress, and installs it for
its users.

PRs that try to fix it get closed:

- DefinitelyTyped/DefinitelyTyped#67000 (review)
- DefinitelyTyped/DefinitelyTyped#44962

I moved `@types/testing-library__cypress` to `peerDependencies`.
hasparus added a commit to hasparus/synpress that referenced this pull request Feb 7, 2024
Due to a design limitation in DefinitelyTyped, it doesn't support
`peerDependencies`. This means that Synpress, even when used with
Playwright, transitively depends on Cypress, and installs it for
its users.

PRs that try to fix it get closed:

- DefinitelyTyped/DefinitelyTyped#67000 (review)
- DefinitelyTyped/DefinitelyTyped#44962

I moved `@types/testing-library__cypress` to `peerDependencies`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Perf: Same typescript-bot determined that this PR will not significantly impact compilation performance. Popular package This PR affects a popular package (as counted by NPM download counts).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants