-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eslint] add cacheStategy
option
#53485
Conversation
@rafaelss95 Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it. You can test the changes in this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 53485,
"author": "rafaelss95",
"headCommitOid": "afc4a0b822bde69628b8689b498b3b9832607fe2",
"lastPushDate": "2021-05-29T00:56:58.000Z",
"lastActivityDate": "2021-06-01T21:25:11.000Z",
"maintainerBlessed": "Waiting for Code Reviews",
"mergeOfferDate": "2021-06-01T21:12:18.000Z",
"mergeRequestDate": "2021-06-01T21:25:11.000Z",
"mergeRequestUser": "rafaelss95",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "eslint",
"kind": "edit",
"files": [
{
"path": "types/eslint/eslint-tests.ts",
"kind": "test"
},
{
"path": "types/eslint/index.d.ts",
"kind": "definition"
}
],
"owners": [
"pmdartus",
"j-f1",
"saadq",
"JasonHK",
"bradzacher",
"JounQin"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "JounQin",
"date": "2021-05-29T01:52:43.000Z",
"isMaintainer": false
}
],
"mainBotCommentID": 850741041,
"ciResult": "pass"
} |
🔔 @pmdartus @j-f1 @saadq @JasonHK @bradzacher @JounQin — please review this PR in the next few days. Be sure to explicitly select |
@rafaelss95 Everything looks good here. Great job! I am ready to merge this PR (at afc4a0b) on your behalf. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@pmdartus, @j-f1, @saadq, @JasonHK, @bradzacher, @JounQin: you can do this too.) |
Ready to merge |
I just published |
Please fill in this template.
npm test <package to test>
.Select one of these and delete the others:
If changing an existing definition: