Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@types/react-reconciler): typo supportsMicrotask -> supportsMicro… #63837

Merged

Conversation

AdvancedCat
Copy link
Contributor

…tasks

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

According to a PR facebook/react#25142 from React, fix this typo error.

@typescript-bot
Copy link
Contributor

typescript-bot commented Jan 7, 2023

@AdvancedCat Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Only a DT maintainer can approve changes without tests

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63837,
  "author": "AdvancedCat",
  "headCommitOid": "2d35182691701042232885e47b14395cc620a646",
  "mergeBaseOid": "f27752ff52775d9f678d12f4f48f5eeaf75d9dee",
  "lastPushDate": "2023-01-07T10:58:37.000Z",
  "lastActivityDate": "2023-01-12T01:26:17.000Z",
  "mergeOfferDate": "2023-01-11T21:49:21.000Z",
  "mergeRequestDate": "2023-01-12T01:26:17.000Z",
  "mergeRequestUser": "mathieudutour",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-reconciler",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-reconciler/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Methuselah96",
        "zhanghaocong",
        "mathieudutour"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "rbuckton",
      "date": "2023-01-11T21:48:35.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "mathieudutour",
      "date": "2023-01-09T08:44:31.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1374441024,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels Jan 7, 2023
@typescript-bot
Copy link
Contributor

Hey @AdvancedCat,

😒 Your PR doesn't modify any tests, so it's hard to know what's being fixed, and your changes might regress in the future. Please consider adding tests to cover the change you're making. Including tests allows this PR to be merged by yourself and the owners of this module.

This can potentially save days of time for you!

@typescript-bot
Copy link
Contributor

🔔 @Methuselah96 @zhanghaocong @mathieudutour — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@DangerBotOSS
Copy link

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-reconciler (unpkg)

was missing the following properties:

  1. attemptContinuousHydration
  2. attemptDiscreteHydration
  3. attemptHydrationAtCurrentPriority
  4. attemptSynchronousHydration
  5. batchedUpdates
as well as these 30 other properties...

createComponentSelector, createContainer, createHasPseudoClassSelector, createHydrationContainer, createPortal, createRoleSelector, createTestNameSelector, createTextSelector, deferredUpdates, discreteUpdates, findAllNodes, findBoundingRects, findHostInstance, findHostInstanceWithNoPortals, findHostInstanceWithWarning, flushControlled, flushPassiveEffects, flushSync, focusWithin, getCurrentUpdatePriority, getFindAllNodesFailureDescription, getPublicRootInstance, injectIntoDevTools, isAlreadyRendering, observeVisibleRects, registerMutableSourceForHydration, runWithPriority, shouldError, shouldSuspend, updateContainer

Generated by 🚫 dangerJS against 2d35182

@typescript-bot typescript-bot added the Owner Approved A listed owner of this package signed off on the pull request. label Jan 9, 2023
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 11, 2023
@typescript-bot
Copy link
Contributor

@AdvancedCat: Everything looks good here. I am ready to merge this PR (at 2d35182) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Methuselah96, @zhanghaocong, @mathieudutour: you can do this too.)

@mathieudutour
Copy link
Contributor

Ready to merge

@typescript-bot typescript-bot merged commit 6118fbb into DefinitelyTyped:master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintainer Approved Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants