Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dayjs type for react-big-calendar #64211

Merged

Conversation

levani132
Copy link
Contributor

@levani132 levani132 commented Feb 3, 2023

Added dayjsLocalizer type that was added in this PR: jquense/react-big-calendar#2264

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: <>
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Feb 3, 2023

@levani132 Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 64211,
  "author": "levani132",
  "headCommitOid": "d4cf88aad9677deb8a3dc63d2a49c2ea7be52db9",
  "mergeBaseOid": "8e8c5b14eac1ee0a75ee2d3987e5d89bd1d9aa17",
  "lastPushDate": "2023-02-03T13:49:13.000Z",
  "lastActivityDate": "2023-02-03T14:01:25.000Z",
  "mergeOfferDate": "2023-02-03T14:00:02.000Z",
  "mergeRequestDate": "2023-02-03T14:01:25.000Z",
  "mergeRequestUser": "levani132",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-big-calendar",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-big-calendar/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-big-calendar/react-big-calendar-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "piotrwitek",
        "paustint",
        "pikpok",
        "eps1lon",
        "strongpauly",
        "janb87",
        "siavelis",
        "lksilva",
        "SergeyBelofost",
        "marknelissen",
        "KenneyE",
        "PaitoAnderson",
        "michalak111",
        "tomtom5152",
        "catruzz",
        "princefishthrower",
        "decimoseptimo"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "michalak111",
      "date": "2023-02-03T13:59:17.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 1415822675,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Feb 3, 2023
@typescript-bot
Copy link
Contributor

🔔 @piotrwitek @paustint @pikpok @eps1lon @strongpauly @janb87 @siavelis @lksilva @SergeyBelofost @marknelissen @KenneyE @PaitoAnderson @michalak111 @tomtom5152 @catruzz @princefishthrower @decimoseptimo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 3, 2023
@typescript-bot
Copy link
Contributor

@levani132 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 3, 2023
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Feb 3, 2023
@typescript-bot
Copy link
Contributor

@levani132 The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Feb 3, 2023
@DangerBotOSS
Copy link

DangerBotOSS commented Feb 3, 2023

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

react-big-calendar (unpkg)

was missing the following properties:

  1. components

Generated by 🚫 dangerJS against d4cf88a

@levani132 levani132 changed the title Levani132 add dayjs type rbg Add dayjs type react-big-calendar Feb 3, 2023
@levani132 levani132 changed the title Add dayjs type react-big-calendar Add dayjs type for react-big-calendar Feb 3, 2023
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Feb 3, 2023
@typescript-bot
Copy link
Contributor

@levani132: Everything looks good here. I am ready to merge this PR (at d4cf88a) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@piotrwitek, @paustint, @pikpok, @eps1lon, @strongpauly, @janb87, @siavelis, @lksilva, @SergeyBelofost, @marknelissen, @KenneyE, @PaitoAnderson, @michalak111, @tomtom5152, @catruzz, @princefishthrower, @decimoseptimo: you can do this too.)

@levani132
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 170311d into DefinitelyTyped:master Feb 3, 2023
@levani132 levani132 deleted the levani132-add-dayjs-type-rbg branch February 3, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants