Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean license prompt input #61

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Clean license prompt input #61

merged 4 commits into from
Oct 15, 2024

Conversation

joasode
Copy link
Contributor

@joasode joasode commented Aug 28, 2024

Clears the input buffer before license prompt

Closes #47

@joasode
Copy link
Contributor Author

joasode commented Aug 28, 2024

This fix does not play ball with Pytest when it captures the stdin. Testing locally, I find the tests succeed when pytest is given the "-s" flag to disable capturing. I don't know of a good work-around, as MonkeyPatching stdin to a StringIO won't work https://stackoverflow.com/questions/5903501/attributeerror-stringio-instance-has-no-attribute-fileno

@joasode joasode added the bug Something isn't working label Aug 29, 2024
@joasode joasode changed the title Clean license prompt input Draft: Clean license prompt input Sep 2, 2024
@joasode joasode changed the title Draft: Clean license prompt input Clean license prompt input Sep 2, 2024
@TheBlackKoala TheBlackKoala self-requested a review October 15, 2024 12:13
@joasode joasode merged commit 2172d72 into main Oct 15, 2024
36 checks passed
@joasode joasode deleted the consistent-input branch October 15, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing while spinner is running will add the characters to input
2 participants