Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid triggering whole page initialization if 'init' is called with no arguments #8

Closed
bububo opened this issue Feb 27, 2020 · 0 comments · Fixed by #11
Closed

Avoid triggering whole page initialization if 'init' is called with no arguments #8

bububo opened this issue Feb 27, 2020 · 0 comments · Fixed by #11

Comments

@bububo
Copy link
Collaborator

bububo commented Feb 27, 2020

Currently dcFactory.init() triggers initialization on document.body. We'd like to explicitly pass DOM node to init
@bububo bububo changed the title Avoid triggering whole page initialization in init called with no root argument Avoid triggering whole page initialization if 'init' is called with no arguments Feb 27, 2020
bububo added a commit that referenced this issue Feb 27, 2020
@bububo
#8 // explicitly pass root to dcFactory.init method
eac6d76
@bububo bububo linked a pull request Feb 27, 2020 that will close this issue
#8 // explicitly pass root to dcFactory.init method #11
Merged
skvigl added a commit that referenced this issue Jun 3, 2020
@skvigl
Merge pull request #11 from Delete-Agency/feature/#8-mandatory-root-a…
eace57d 
…rgument

#8 // explicitly pass root to dcFactory.init method
@skvigl skvigl closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#8 // explicitly pass root to dcFactory.init method Delete-Agency/dc
2 participants
@skvigl @bububo