Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise an exception if "logger.catch()" is used to wrap a class #623

Closed
Delgan opened this issue Mar 22, 2022 · 0 comments
Closed

Raise an exception if "logger.catch()" is used to wrap a class #623

Delgan opened this issue Mar 22, 2022 · 0 comments
Labels
enhancement Improvement to an already existing feature

Comments

@Delgan
Copy link
Owner

Delgan commented Mar 22, 2022

It may lead to unexpected behavior (see #621).

Another suggestion was to wrap all methods of the decorated class, but it's too dangerous in my opinion (in particular because the wrapped function returns None on Exception by default).
@Delgan Delgan added the enhancement Improvement to an already existing feature label Mar 22, 2022
Delgan added a commit that referenced this issue May 2, 2022
@Delgan
Raise exception if "catch()" wraps a class and not a function (#623)
1d9d58c
@Delgan Delgan closed this as completed May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an already existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Delgan