Feature/async require support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdowdle
reviewed
Jun 1, 2017
tests/mochs/MochComponent.jsx
Outdated
| @@ -25,7 +26,7 @@ class MochComponent extends React.Component { | |||
| } | |||
|
|
|||
| MochComponent.propTypes = { | |||
| title: React.PropTypes.string, | |||
| title: PropTypes.string, | |||
| }; | |||
|
|
|||
| export default MochComponent; | |||
There was a problem hiding this comment.
Is there a reason this is called MochComponent instead of MockComponent? Or is it just a typo?
jeffdowdle
reviewed
Jun 1, 2017
src/Bootstrapper.js
Outdated
| const factory = container.domFactory(); | ||
| const id = container.id(); | ||
| const q = []; |
There was a problem hiding this comment.
Might be nice to give this a more descriptive name, even if it's just queue.
There was a problem hiding this comment.
Yep good idea, changed for resolveQueue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys,
Can you check this one too when you get a chance please.
This now adds code splitting support by using Promises to resolve components and fixes issue #2. I've also update the docs substantially so its a bit easier to navigate since they are so huge. You can preview them here.