Update to only warn if child contains components #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Updated passing props back readme Removed optimise plugin from examples (to keep it simple) Updated ready TOC Added links to prop types in readme Updated api to hand prop types of numbers and references. Updated read me. Changed module exports for DeloitteAU#4 Added examples Fixed issue with errors been thrown for elements with white space and linebreaks Fixed issue with parsing empty array's and object's DeloitteAU#3 Added failing tests for DeloitteAU#3 Updated build + tests Conflicts: dist/react-habitat.js dist/react-habitat.min.js lib/Container.js
* develop: Fixed typo Readme link fixes Experiment with toc Fixed links Updated docs Fixed issue in es5 example
- Remove logic warning of any children from Habitat.js - Add logic to check if element contains any elements with an attribute matching the custom selector to Bootstrapper.js and add new warning for this case - Update tests and build Fixes DeloitteAU#5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matching the custom selector to Bootstrapper.js and add new warning
for this case
Fixes #5