Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add issues for the interesting parts of the code we removed. #64

Closed
Tracked by #62
semanticphilosopher opened this issue Dec 9, 2024 · 4 comments
Closed
Tracked by #62

Comments

@semanticphilosopher
Copy link
Collaborator

No description provided.

@HeinrichApfelmus
Copy link
Collaborator

HeinrichApfelmus commented Dec 11, 2024

Peter has already added issues #49 and #50.

I have added issues #74, #75, and #76.

@peterwthompson As you are more familiar with the previous codebase, could you do one last check to see whether we're missing anything else? If you're positive that we haven't missed anything interesting, feel free to close this issue.

@semanticphilosopher
Copy link
Collaborator Author

I've read and commented (where I had input) on the referenced issues.

I can't think of anything else from the old code base that we should add here.

I am happy that this issue is closed. - @peterwthompson over to you

@peterwthompson
Copy link
Collaborator

peterwthompson commented Dec 12, 2024 via email

@HeinrichApfelmus
Copy link
Collaborator

The only other things we used to have that I can’t see equivalents of in the new version are ‘multiple’ versions of other functions, which are more efficient than just multiple applications of the simple versions.

Ok, I have added issue #78 for this remaining point.

Closing this issue, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants