-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add issues for the interesting parts of the code we removed. #64
Comments
Peter has already added issues #49 and #50. I have added issues #74, #75, and #76. @peterwthompson As you are more familiar with the previous codebase, could you do one last check to see whether we're missing anything else? If you're positive that we haven't missed anything interesting, feel free to close this issue. |
I've read and commented (where I had input) on the referenced issues. I can't think of anything else from the old code base that we should add here. I am happy that this issue is closed. - @peterwthompson over to you |
The only other things we used to have that I can’t see equivalents of in the new version are ‘multiple’ versions of other functions, which are more efficient than just multiple applications of the simple versions.
centiles :: (Fractional a, Ord a, Num a, Enum a, Eq a, Evaluable a (Poly a), Integrable (DistD a) (DistP a)) => [a] -> IRV a -> [Maybe a]
multiWeightedChoice :: (Fractional a, Ord a, Num a, Enum a, Eq a, Differentiable (DistP a) (DistD a)) => [(a, IRV a)] -> IRV a
multiAtF :: (Fractional a, Ord a, Num a, Enum a, Eq a, Integrable (DistD a) (DistP a)) => [IRV a] -> IRV a
multiFtF :: (Fractional a, Ord a, Num a, Enum a, Eq a, Integrable (DistD a) (DistP a)) => [IRV a] -> IRV a
On 11 Dec 2024, at 20:24, Neil Davies ***@***.***> wrote:
I've read and commented (where I had input) on the referenced issues.
I can't think of anything else from the old code base that we should add here.
I am happy that this issue is closed. - @peterwthompson <https://github.com/peterwthompson> over to you
—
Reply to this email directly, view it on GitHub <#64 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABUQ5PH4DB4AYQG4SKPTURD2FCNRDAVCNFSM6AAAAABTISM6FOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMZXGA2TENBQGQ>.
You are receiving this because you were mentioned.
<http://pnsol.com/>
Peter Thompson <http://uk.linkedin.com/in/peterthompson>, Consultant Scientist
Predictable Network Solutions Ltd. <http://pnsol.com/>,
+44 (0)333.340.7713 <tel:+443333407713> • Twitter: @PNSolLtd <http://twitter.com/PNSolLtd>
|
Ok, I have added issue #78 for this remaining point. Closing this issue, feel free to reopen. |
No description provided.
The text was updated successfully, but these errors were encountered: