Feature/108 apply a measure selection strategy to all locations #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…q operators in `PointSurroundings`
…atures across a dike traject based on default order
…e location matrix
2 tasks
ArdtK
reviewed
Oct 25, 2023
| ] | ||
| self._location_matrix = strategy_input.locations_matrix | ||
| self._structure_buffer = strategy_input.structure_buffer | ||
| self._min_space_between_structures = strategy_input.min_space_between_structures |
There was a problem hiding this comment.
Correct, this is preliminary work for #110
| locations_profile_report_list: list[MultiLocationProfileCostReport] | ||
| available_locations: list[PointSurroundings] | ||
|
|
||
| def __init__( |
There was a problem hiding this comment.
How does this match with the design principle of parameterless init?
| _matrix[_reinforcement_per_location.location] = _suitable_locations + [ | ||
| _reinforcement_per_location.selected_measure.output_name | ||
| ] | ||
|
|
There was a problem hiding this comment.
Will you add tests for the strategies?
There was a problem hiding this comment.
Yes, but once the code in OrderStrategy is final, as we are already checking via other tests (in #112 ) whether the extra column with selected measure exists.
I'm also doubting whether to introduce already a protocol or wait until we have anotherstrategy case.
I also just realized I wrote order_stategy.py instead of order_strategy.py I will correct that in #110
Carsopre
deleted the
feature/108-apply-a-measure-selection-strategy-to-all-locations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.