-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/81 definition of testcases #88
Conversation
…Deltares/Koswat into test/81-definition-of-testcases
…etter readability and maintainability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I don't get all the details (yet)
@@ -52,7 +66,7 @@ def test_koswat_package_can_be_imported(self): | |||
LayersCases.cases, | |||
) | |||
@pytest.mark.slow | |||
def test_koswat_run_as_sandbox( | |||
def test_koswat_run_as_sandbox_phased_out( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what reason would you like to keep tests that seem to be phased out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Until we have a 'green' test bench (almost end of the sprint) will be handy to keep this tests and ensure nothing is getting out of hand.
…lculating new reinforcements
…Deltares/Koswat into test/81-definition-of-testcases
No description provided.