Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/81 definition of testcases #88

Merged
merged 21 commits into from
Oct 18, 2023
Merged

Conversation

Carsopre
Copy link
Collaborator

No description provided.

@Carsopre Carsopre linked an issue Oct 17, 2023 that may be closed by this pull request
Copy link
Contributor

@ArdtK ArdtK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I don't get all the details (yet)

@@ -52,7 +66,7 @@ def test_koswat_package_can_be_imported(self):
LayersCases.cases,
)
@pytest.mark.slow
def test_koswat_run_as_sandbox(
def test_koswat_run_as_sandbox_phased_out(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what reason would you like to keep tests that seem to be phased out?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we have a 'green' test bench (almost end of the sprint) will be handy to keep this tests and ensure nothing is getting out of hand.

@Carsopre Carsopre merged commit 77aa61e into master Oct 18, 2023
@Carsopre Carsopre deleted the test/81-definition-of-testcases branch October 18, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition of testcases
3 participants