Feature/86 read and stack multiple surroundings layers #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd-stack-multiple-surroundings-layers
chore: generalize buildings to surroundings in polderside functions
Carsopre
reviewed
Oct 19, 2023
koswat/dike/surroundings/wrapper/surroundings_wrapper_builder.py
Outdated
Show resolved
Hide resolved
5 tasks
ArdtK
commented
Oct 20, 2023
There was a problem hiding this comment.
@Carsopre I processed the review comment. We need to discuss the way locations are referenced. Doing a deepcopy created need objects, while they are referenced to the original objects.
Next to that I added a testcase for the surrounding_wrapper to test the functionality of getting the "safe" points, depending on the distance of different surroundings and their flags. This could be expanded with more combinations of distances and flags.
Carsopre
reviewed
Oct 23, 2023
Comment on lines
78
to
84
| return next( | ||
| ( | ||
| _loc | ||
| for _loc in locations | ||
| if _loc.traject_order == location.traject_order | ||
| ), | ||
| ) |
There was a problem hiding this comment.
If you don't need the default value you can simplify the next statement.
Also, if possible, replace the List usage with list in this file.
Suggested change
| return next( | |
| ( | |
| _loc | |
| for _loc in locations | |
| if _loc.traject_order == location.traject_order | |
| ), | |
| ) | |
| return next( _loc for _loc in locations if _loc.traject_order == location.traject_order ) |
Carsopre
approved these changes
Oct 23, 2023
… of https://github.com/Deltares/Koswat into feature/86-read-and-stack-multiple-surroundings-layers # Conflicts: # koswat/cost_report/io/csv/summary_matrix_csv_fom_builder.py
ArdtK
deleted the
feature/86-read-and-stack-multiple-surroundings-layers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.