Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move release script to Python and run it with pixi #1029

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Conversation

Hofer-Julian
Copy link
Contributor

Fixes #987

@Hofer-Julian
Copy link
Contributor Author

@Manangka

pixi.toml Outdated Show resolved Hide resolved
Hofer-Julian and others added 2 commits February 1, 2024 16:42
Co-authored-by: Martijn Visser <mgvisser@gmail.com>
echo "Release created successfully."

else
echo "No tag is currently checked out."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to check for the "No tag is currently checked out." condition anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed. I tested it locally and git returns with an error code if there's no tag.

@Hofer-Julian Hofer-Julian merged commit 793fdd7 into main Feb 2, 2024
17 checks passed
@Hofer-Julian Hofer-Julian deleted the gh-release branch February 2, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move release script to Python and run it with pixi
2 participants