-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying coordinate reference system (CRS) of geometries #1339
Conversation
Fixes #1254 Breaking changes: - Adds new required TOML key "crs" - Adds new required `Model` parameter "crs"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think adding the TOML key is fine. I added some commits. Notably a test that "Basin / area" also gets the CRS, but that fails, so I think that still needs to be fixed.
If it is hard to fix it is fine as-is, but currently the Node tables only gets a CRS when it is assembled by node_table()
. That means if you just want the GeoDataframe of the Basin nodes with model.basin.node
you get a GeoDataframe with no CRS set.
Yeah, I don't know how that would be done. When we run |
Would it make sense to define |
Indeed. As I mentioned in #1254, I would probably implement both |
Sounds good to me. |
Fixes #1254
Breaking changes:
Model
parameter "crs" in Ribasim-Python.Note: we could avoid adding the TOML key by requiring
Model.read
to takecrs
as parameter. Not sure if that's an improvement though.Upgrade instructions
Specify the CRS. For instance for WGS 84 latitude longitude, use
crs = "EPSG:4326"
, for the Netherlands usecrs = "EPSG:28992"
.