Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add the endtime to basin.arrow results #1359

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Don't add the endtime to basin.arrow results #1359

merged 3 commits into from
Apr 8, 2024

Conversation

visr
Copy link
Member

@visr visr commented Apr 4, 2024

This reverts a part of 4ff9987

On Tuesday we discussed the basin.arrow with @SouthEndMusic and @Huite. A few issues/PRs will come out of this, but this already removes the endtime, such that we don't have missing vertical fluxes in basin.arrow anymore. The downside is that the final storage is not currently available, but we have #1358 for that, and plan to add dS/dt (m3/s) as well to be able to compute it.

@@ -708,20 +708,20 @@ derivative | Float64 | - | -
The basin table contains:

- results of the storage and level of each basin, which are instantaneous values;
- results of the vertical fluxes on each basin, which are mean values over the `saveat` intervals. In the time column the start of the period is indicated. This means that for the final time in the table the mean vertical fluxes are not computed, and thus are `missing`.
- results of the vertical fluxes on each basin, which are mean values over the `saveat` intervals. In the time column the start of the period is indicated.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also explicitly indicate here that the final state of the model is absent?

@visr visr merged commit f42250a into main Apr 8, 2024
24 checks passed
@visr visr deleted the tminus1 branch April 8, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants