Don't add the endtime to basin.arrow results #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SouthEndMusic
approved these changes
Apr 8, 2024
docs/core/usage.qmd
Outdated
| @@ -708,20 +708,20 @@ derivative | Float64 | - | - | |||
| The basin table contains: | |||
|
|
|||
| - results of the storage and level of each basin, which are instantaneous values; | |||
| - results of the vertical fluxes on each basin, which are mean values over the `saveat` intervals. In the time column the start of the period is indicated. This means that for the final time in the table the mean vertical fluxes are not computed, and thus are `missing`. | |||
| - results of the vertical fluxes on each basin, which are mean values over the `saveat` intervals. In the time column the start of the period is indicated. | |||
There was a problem hiding this comment.
Maybe also explicitly indicate here that the final state of the model is absent?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a part of 4ff9987
On Tuesday we discussed the
basin.arrowwith @SouthEndMusic and @Huite. A few issues/PRs will come out of this, but this already removes the endtime, such that we don't havemissingvertical fluxes inbasin.arrowanymore. The downside is that the final storage is not currently available, but we have #1358 for that, and plan to adddS/dt (m3/s)as well to be able to compute it.