Increase performance by reducing lookups #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, TRC, Manning, Outlet
evetion
requested changes
May 8, 2024
There was a problem hiding this comment.
Nice to see such speedups! Most of my remarks are about readability, so I would also ask you to write in the description (which will turn into the commit message) why and how you did things. Can only be a few lines, but it should explain the changes to all nodes (now storing edges instead of node ids).
evetion
approved these changes
May 13, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1456. The main speedup is due to adding basin indices to the edge metadata, and precalculating vectors of the metadata of inflow and outflow edges of several node types.