Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allocation refactoring #1503

Merged
merged 18 commits into from
Jun 3, 2024
Merged

Allocation refactoring #1503

merged 18 commits into from
Jun 3, 2024

Conversation

Jingru923
Copy link
Contributor

Fixes #1465

@Jingru923 Jingru923 linked an issue May 28, 2024 that may be closed by this pull request
Refactor allocation code #1465
Closed
5 tasks
@Jingru923 Jingru923 changed the title split function allocation into 3 functions Allocation refactoring May 28, 2024
SouthEndMusic
SouthEndMusic requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I added some comments

core/src/allocation_optim.jl Outdated Show resolved Hide resolved
core/src/allocation_optim.jl Outdated Show resolved Hide resolved
core/src/allocation_optim.jl Outdated Show resolved Hide resolved
core/src/allocation_optim.jl Outdated Show resolved Hide resolved
core/src/allocation_optim.jl Outdated Show resolved Hide resolved
pixi.lock Show resolved Hide resolved
docs/core/allocation.qmd Outdated Show resolved Hide resolved
docs/contribute/addnode.qmd Outdated Show resolved Hide resolved
core/test/allocation_test.jl Show resolved Hide resolved
core/src/callback.jl Outdated Show resolved Hide resolved
SouthEndMusic
SouthEndMusic approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a few last nitpicks, but other than that it is good to go!

core/src/allocation_optim.jl Outdated Show resolved Hide resolved
core/src/allocation_optim.jl Outdated Show resolved Hide resolved
core/src/callback.jl Outdated Show resolved Hide resolved
core/test/allocation_test.jl Outdated Show resolved Hide resolved
core/test/allocation_test.jl Outdated Show resolved Hide resolved
docs/core/allocation.qmd Outdated Show resolved Hide resolved
@Jingru923 Jingru923 merged commit 3a443e9 into main Jun 3, 2024
24 of 25 checks passed
@Jingru923 Jingru923 deleted the refactor-allocation-code branch June 3, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr left review comments

@SouthEndMusic SouthEndMusic SouthEndMusic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor allocation code
3 participants
@Jingru923 @visr @SouthEndMusic