Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipykernel to pixi deps #1542

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Add ipykernel to pixi deps #1542

merged 3 commits into from
Jun 10, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Jun 7, 2024

Not sure if manifest version 5 will cause trouble.

I use VS Code for interactive development, which requires ipykernel. Since VS Code uses the pixi env, I always end up adding ipykernel in the past months. Seems like a good developer addition.

Similarly, I always limit the pyarrow version, as I otherwise get a

  File "/Users/evetion/code/Ribasim.jl/.pixi/envs/dev/lib/python3.12/site-packages/pandas/compat/pyarrow.py", line 10, in <module>
    _palv = Version(Version(pa.__version__).base_version)
                            ^^^^^^^^^^^^^^
AttributeError: module 'pyarrow' has no attribute '__version__'

I'm not sure why the CI doesn't reproduce this.

@evetion evetion requested a review from visr June 7, 2024 17:26
@evetion
Copy link
Member Author

evetion commented Jun 7, 2024

Ah the manifest needs #1491. Downgraded it for now.

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seem fine to me. I'm a bit surprised about ipykernel, I use interactive Python in VSCode all the time but don't run into this. But the VSCode docs do mention it needs an ipykernel install, so let's add it.

I've also run into the pyarrow version issue. So far re-installing the pixi environment worked for me. But capping the version is probably more robust for now.

pixi.toml Outdated Show resolved Hide resolved
@visr visr merged commit 25e7777 into main Jun 10, 2024
20 checks passed
@visr visr deleted the feat/add-ipykernel branch June 10, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants