Require QGIS 3.34 (LTR); remove activation scripts #1627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the only thing we use from a newer QGIS (3.32) is
Qgis.AttributeFormSuppression.On
. So we could technically still support older versions. Though since 3.34 is the new Long Term Release, and we have yet to release v1.0, it is best to make it clear what we'll support now.This also removes the activation scripts, including
open-vscode.bat
. With this VSCode Python release, it now correctly locates pixi environments. I added instructions on this in the dev docs.The mypy settings still affected 4 issues in the QGIS Python code. All are of this type:
I added type ignores for those four, I don't think this disables much effective functionality since mypy still finds issues inside the class.