Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require QGIS 3.34 (LTR); remove activation scripts #1627

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Require QGIS 3.34 (LTR); remove activation scripts #1627

merged 4 commits into from
Jul 17, 2024

Conversation

visr
Copy link
Member

@visr visr commented Jul 16, 2024

Currently the only thing we use from a newer QGIS (3.32) is Qgis.AttributeFormSuppression.On. So we could technically still support older versions. Though since 3.34 is the new Long Term Release, and we have yet to release v1.0, it is best to make it clear what we'll support now.

This also removes the activation scripts, including open-vscode.bat. With this VSCode Python release, it now correctly locates pixi environments. I added instructions on this in the dev docs.

The mypy settings still affected 4 issues in the QGIS Python code. All are of this type:

ribasim_qgis\ribasim_qgis.py:11: error: Class cannot subclass "QgsDockWidget" (has type "Any")  [misc]

I added type ignores for those four, I don't think this disables much effective functionality since mypy still finds issues inside the class.

@Huite
Copy link
Contributor

Huite commented Jul 17, 2024

I think moving to the newest LTR is good, also as a precedent. Although changes are generally minor (e.g. AttributeFormSuppression), it makes our life easier to have "lastest LTR" as a policy.

The only thing I'm not sure about is whether people who older versions of QGIS will be notified about newer versions of the plugin in their older QGIS version. It would be good to add this very explicitly in the documentation.

The current Install docs don't mention QGIS very explicitly: https://deltares.github.io/Ribasim/install.html

Maybe add a section there?

I would also suggest adding a note in the README.md of the repo. There's a link to download the plugin there.

@visr visr mentioned this pull request Jul 17, 2024
@visr
Copy link
Member Author

visr commented Jul 17, 2024

The only thing I'm not sure about is whether people who older versions of QGIS will be notified about newer versions of the plugin in their older QGIS version.

I don't know the answer, but this would only apply if we register the QGIS plugin, and we don't do that yet.

I listed your other suggestions in #1630.

@visr visr merged commit 2853e59 into main Jul 17, 2024
24 of 25 checks passed
@visr visr deleted the less branch July 17, 2024 08:57
@Huite
Copy link
Contributor

Huite commented Jul 17, 2024

if we register the QGIS plugin, and we don't do that yet

Excellent point, totally forgot about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants