Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BackTracking in non-linear interations #1697

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Use BackTracking in non-linear interations #1697

merged 3 commits into from
Aug 6, 2024

Conversation

SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Aug 6, 2024 •
edited by visr
Loading

Fixes #1414

As suggested by @Huite: #1414 (comment).

@SouthEndMusic
Copy link
Collaborator Author

With this, the hws_2024_7_1 model runs in 45 seconds 😵‍💫

@SouthEndMusic SouthEndMusic mentioned this pull request Aug 6, 2024
Closed
@visr visr mentioned this pull request Aug 6, 2024
Closed
visr
visr approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo that's a 10x performance improvement! Thanks @Huite @SouthEndMusic!

@SouthEndMusic SouthEndMusic merged commit 4ee738e into main Aug 6, 2024
26 of 30 checks passed
@SouthEndMusic SouthEndMusic deleted the backtracking branch August 6, 2024 12:18
This was referenced Aug 8, 2024
Closed
Closed
This was referenced Aug 8, 2024
Closed
Merged
visr added a commit that referenced this pull request Aug 13, 2024
@visr
Use a fixed relaxation factor of 0.1 (#1715)
c75cfdc 
Fixes a part of #1705.

This no longer has the huge speedup of #1697, but still a good 10-20%
performance improvement, and no breakdowns. If we go over to
NonLinearSolve.jl it probably makes sense to try out other algorithms
again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convergence of large outflows from small Basins
2 participants
@SouthEndMusic @visr