Add 2x 4x and 0.5x speed selection menu #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hvangeffen
commented
Jan 18, 2024
hvangeffen
commented
|
Switch icon to mdi-play-speed |
|
Add playback speed tooltip |
|
Setinterval to settimeout |
hvangeffen
force-pushed
the
610-add-2x-4x-speed-in-selection-menu-on-datetimeslider
branch
from
e6e085f to
af488f3
Compare
hvangeffen
force-pushed
the
610-add-2x-4x-speed-in-selection-menu-on-datetimeslider
branch
from
af488f3 to
f156437
Compare
hvangeffen
commented
Jan 24, 2024
hvangeffen
force-pushed
the
610-add-2x-4x-speed-in-selection-menu-on-datetimeslider
branch
from
4af3546 to
467e08e
Compare
vanmeeuwen
approved these changes
Feb 7, 2024
| density="compact" | ||
| variant="text" | ||
| icon="mdi-timer-cog-outline" | ||
| /> |
There was a problem hiding this comment.
Suggested change
| /> | |
| icon="mdi-play-speed" |
| v-bind="props" | ||
| density="compact" | ||
| variant="text" | ||
| icon="mdi-timer-cog-outline" |
There was a problem hiding this comment.
probably add a tooltip: playback speed here
| @@ -265,6 +290,12 @@ function play(): void { | |||
| dateIndex.value = 0 | |||
| } | |||
| increment(playIncrement) | |||
| if (isPlaying.value) { | |||
There was a problem hiding this comment.
We don't need the isPlaying variable anymore, size this is arranged by the playTimeoutTimer.
hvangeffen
deleted the
610-add-2x-4x-speed-in-selection-menu-on-datetimeslider
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.