Move workflow button to toolbar #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bounding box stays active when switching to layer without workflow and or bbox workflow:
|
Maybe disable button or always have a workflow selected
|
WQPS workflow is empty on first selectAfter reopening window
|
Weird spacing on bbox selection click without having drawn a bbox yet
|
We now auto-select the first workflow, so this no longer occurs. |
This is also fixed with auto-selecting the first workflow. In addition, we now show the workflow ID in the selection box if no description of the workflow is provided. |
We now show a dash instead of an empty string when no bounding box has been drawn yet. |
We now stop the bounding box selection and abandon the work flow when switching nodes. |
Workflow button disappears when scrolling
|
Values become NaN and menu / bbox selector break when changing delta to invalid values / below 1 (i.e. 0.3)
|
Now fixed, the toolbar is part of the unscrollable part of the side bar. |
New warning
SpatialDisplay.vue <SpatialDisplayComponent
:layer-name="props.layerName"
:location-id="props.locationId"
:latitude="props.latitude"
:longitude="props.longitude"
:filter-ids="props.filterIds"
@changeLocationId="onLocationChange"
:layer-capabilities="layerCapabilities"
:times="times"
v-model:elevation="elevation"
v-model:current-time="currentTime"
@coordinate-click="onCoordinateClick"
:secondaryWorkflows="secondaryWorkflows"
></SpatialDisplayComponent>Have to remove :secondaryWorkflows here and maybe also in the parents Could also remove the v-show for the other warning: WorkflowsControl.vue:16 <v-dialog v-show="!selectBbox" width="500" v-model="workflowDialog">
<v-card>
<v-card-title>Workflow</v-card-title>
<v-container>
<v-col> |
|
Trying to draw a bounding box with x-step 0.2 and y-step 0.3 leads to errors from Terra Draw for some reason.
|
Terra draw has a default max coordinate precision of 9 decimals. |
hvangeffen
force-pushed
the
DWO-638-move-workflow-button
branch
from
b9a56d1 to
1ba4e0b
Compare
We now use a FEWS PI provider in the WorkflowsControl component, so we no longer need the useWorkflows service.
This type explicitly names its members, so no confusion can exist over which of the 4 values is min/max or latitude/longitude.
This prevents us having to deal with Terra Draw's specific flavour of GeoJSON outside of the drawing component.
This prepares for moving the workflow control to the side bar.
This prepares for moving the workflows button to the side bar. In that case, we need to gather the required information from several independent components, so we use a store to do this.
This is more preparation for moving the workflow button to the sidebar.
Do not keep track of their IDs, we do not need them.
ceesvoesenek
force-pushed
the
DWO-638-move-workflow-button
branch
from
04367e8 to
109ba56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #797
Closes #832
This is a rather involved change since the workflow control needs data from the topology and the current WMS layer (start and end times). Furthermore, I extracted some functionality from
WorkflowControlto separate modules.