Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show unreliable flagged data in time series charts #921

Conversation

hvangeffen
Copy link
Collaborator

@hvangeffen hvangeffen commented Jun 13, 2024

Test location: /topology/node/viewer_rivers_level_stations/viewer_rivers_level_stations_forecast/map/waterdepth_sfincs_inland/location/Umgeni_Mouth_level

Before

image

After

image

@hvangeffen hvangeffen self-assigned this Jun 13, 2024
@hvangeffen hvangeffen force-pushed the 920-unreliable-data-in-a-time-series-table-must-not-be-used-in-scaling-the-y-axis branch from ee3bc89 to ccb60a8 Compare June 13, 2024 09:35
@hvangeffen hvangeffen requested a review from ceesvoesenek June 13, 2024 10:36
Copy link
Collaborator

@ceesvoesenek ceesvoesenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, most important suggestion is to move the "unreliable flags" to the configuration

src/components/charts/ElevationChart.vue Outdated Show resolved Hide resolved
src/lib/charts/dataFromResources.ts Show resolved Hide resolved
@hvangeffen hvangeffen merged commit 18fcbe9 into main Jun 19, 2024
8 checks passed
@hvangeffen hvangeffen deleted the 920-unreliable-data-in-a-time-series-table-must-not-be-used-in-scaling-the-y-axis branch June 19, 2024 09:03
@bogaardt bogaardt changed the title Filter unreliable flagged data from charts Do not show unreliable flagged data in time series charts Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreliable data in a time series table must not be used in scaling the Y-axis
3 participants