Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading icon when get request for time series is pending #932

Merged

Conversation

hvangeffen
Copy link
Collaborator

No description provided.

@hvangeffen hvangeffen requested a review from ceesvoesenek June 18, 2024 14:25
@hvangeffen hvangeffen self-assigned this Jun 18, 2024
@hvangeffen hvangeffen linked an issue Jun 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@ceesvoesenek ceesvoesenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Some minor comments

src/components/charts/LoadingOverlay.vue Outdated Show resolved Hide resolved
src/components/charts/LoadingOverlay.vue Outdated Show resolved Hide resolved
src/components/charts/TimeSeriesChart.vue Outdated Show resolved Hide resolved
src/services/useTimeSeries/index.ts Outdated Show resolved Hide resolved
@wkramer wkramer added this to the Release 1.1.0 milestone Jun 19, 2024
@hvangeffen hvangeffen requested a review from wkramer June 20, 2024 09:35
@wkramer wkramer merged commit 5b08793 into main Jun 20, 2024
8 checks passed
@wkramer wkramer deleted the 928-show-loading-icon-when-get-request-for-time-series-is-pending branch June 20, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show loading icon when GET request for time series is pending
3 participants