TopologyDisplayView: The tab type remains the same (if possible) when the user selects a new node. #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the user selects a new node. The v-btn-toggle was connecting its v-model to the v-btn keys. This caused the model to become meaningless when the node was changed. Using the tab.type as the button value allows the toggle group model to behave as expected and simplifies the code by removing the need for seperate activeTab and activeTabType variables, with activeTab now containing the tab.type string. Some additional cleaning up was performed
MatTolladay
force-pushed
the
912-when-changing-the-topology-node-the-actively-selected-component-reverts-to-the-map
branch
from
c6a7849 to
d2c89f6
Compare
hvangeffen
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Seems to work nicely.
Only when switching between different dataDownloadDisplay's the state is not updated.
This is because dataDonwnloadDisplay is not reactive on the topologyNode prop.
Seperate issue though, but could maybe be fixed in: #947, by adding a key on topologyNode to the new dataDownloadDisplayView
MatTolladay
deleted the
912-when-changing-the-topology-node-the-actively-selected-component-reverts-to-the-map
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The v-btn-toggle was connecting its v-model to the v-btn keys. This caused the model to become meaningless when the node was changed. Using the tab.type as the button value allows the toggle group model to behave as expected and simplifies the code by removing the need for separate activeTab and activeTabType variables, with activeTab now containing the tab.type string.
Some additional cleaning up was performed