-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#137-allow-to-use-different-names-for-the-spatial-exposure-data #141
Merged
frederique-hub
merged 2 commits into
fiat_integrator
from
#137-allow-to-use-different-names-for-the-spatial-exposure-data
Sep 28, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
|
||
jrc_vulnerability_curves: | ||
path: damage_functions/flooding/JRC_damage_functions.csv | ||
data_type: DataFrame | ||
driver: csv | ||
meta: | ||
category: vulnerability | ||
description: JRC depth-damage functions for flooding, processed into a handy format for HydroMT-FIAT. | ||
source_url: https://publications.jrc.ec.europa.eu/repository/handle/JRC105688 | ||
paper_ref: Huizinga, J., De Moel, H. and Szewczyk, W., Global flood depth-damage functions - Methodology and the database with guidelines, EUR 28552 EN, Publications Office of the European Union, Luxembourg, 2017, ISBN 978-92-79-67781-6, doi:10.2760/16510, JRC105688. | ||
paper_doi: https://dx.doi.org/10.2760/16510 | ||
|
||
jrc_vulnerability_curves_linking: | ||
path: vulnerability_linking/JRC_damage_functions_linking.csv | ||
data_type: DataFrame | ||
driver: csv | ||
meta: | ||
category: vulnerability | ||
description: Default linking table for the JRC damage functions (e.g., the residential damage function links to residential buildings). | ||
|
||
jrc_damage_values: | ||
path: max_potential_damages/JRC_base_damage_values.csv | ||
data_type: DataFrame | ||
driver: csv | ||
meta: | ||
category: vulnerability | ||
description: Base damage values from the JRC publicated Excel from the tab "MaxDamage-Data", processed into a handy format for HydroMT-FIAT. | ||
source_url: https://publications.jrc.ec.europa.eu/repository/handle/JRC105688 | ||
paper_ref: Huizinga, J., De Moel, H. and Szewczyk, W., Global flood depth-damage functions - Methodology and the database with guidelines, EUR 28552 EN, Publications Office of the European Union, Luxembourg, 2017, ISBN 978-92-79-67781-6, doi:10.2760/16510, JRC105688. | ||
paper_doi: https://dx.doi.org/10.2760/16510 |
2 changes: 1 addition & 1 deletion
2
...flooding/JRC_damage_functions_linking.csv → ..._linking/JRC_damage_functions_linking.csv
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
Name,Link,Damage Type,type | ||
FIAT Damage Function Name,Exposure Link,Damage Type,type | ||
residential,residential,total,residential | ||
commercial,commercial,total,commercial | ||
industrial,industrial,total,industrial |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just for my understanding: the function set_geom_names is defined here but it is already used above.
is self.set_geom_names somewhere else defined beforehand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question - I did not even think about it because it just worked. It is indeed used in line 244 and only defined in line 246. I think that is possible because they are functions within a class and they are all loaded at initialization of the class. This page explains a bit more: https://stackoverflow.com/questions/29055698/does-the-order-of-variables-and-functions-matter-in-class-python . If you want to read about classes in Python, the documentation is here: https://docs.python.org/3/tutorial/classes.html, although I don't think it's the most clear documentation