#64 flexible aggregation area #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from Fiat integrator
first draft of aggregation file documentation. work in progress!
…res/hydromt_fiat into #64FlexibleAggregationArea
update aggregation
…res/hydromt_fiat into #64FlexibleAggregationArea
… vulnerability curves now.
frederique-hub
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Hi Sarah, very nice job and nice example! I have put some comments and suggestions there. I think they are some small things that you can change in your branch and then just commit and push, the Pull Request will be updated with your new changes. I'll also take some time this week to go over the example in the notebook. Let me know if anything is unclear or you have any questions!
Co-authored-by: frederique-hub <72015981+frederique-hub@users.noreply.github.com>
…res/hydromt_fiat into #64FlexibleAggregationArea
|
@frederique-hub updated the branch. Please review again |
|
There are still some local paths in the test_aggregation_areas.py. I will update that to be a relative path and then accept the changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation update of adding aggregation zones + example notebook