Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes in hazard setup #255

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Bug fixes in hazard setup #255

merged 5 commits into from
Jan 4, 2024

Conversation

panosatha
Copy link
Collaborator

@panosatha panosatha commented Dec 19, 2023 •
edited
Loading

Some changes mainly related to the hazard class:

  • allow for directly providing a DataXarray as hazard input instead of a path.
  • changes naming of the bands in the hazard netcdf to ensure that FIAT handles correct the naming (there was an issue before that the RP's where turned to floats)
  • fixed bug where the unit converson was not implemented

@panosatha panosatha requested a review from Mares2022 December 19, 2023 17:04
@panosatha panosatha mentioned this pull request Dec 22, 2023
Merged
@panosatha panosatha requested a review from LuukBlom December 22, 2023 13:38
@panosatha panosatha requested a review from GundulaW December 22, 2023 15:54
@panosatha panosatha changed the title Xarray as hazard input Bug fixes in hazard setup Dec 22, 2023
GundulaW
GundulaW reviewed Dec 22, 2023
View reviewed changes
Copy link

@GundulaW GundulaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

GundulaW
GundulaW approved these changes Dec 22, 2023
View reviewed changes
Copy link

@GundulaW GundulaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@LuukBlom LuukBlom merged commit 77f5ad4 into main Jan 4, 2024
1 check passed
@panosatha panosatha deleted the xarray_as_hazard_input branch June 10, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dladrichem dladrichem dladrichem approved these changes

@GundulaW GundulaW GundulaW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panosatha @GundulaW @dladrichem @LuukBlom