Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected code for splitting new composite areas #408

Merged
merged 1 commit into from
Oct 31, 2024
Merged

corrected code for splitting new composite areas #408

merged 1 commit into from
Oct 31, 2024

Conversation

panosatha
Copy link
Collaborator

@panosatha panosatha commented Oct 30, 2024 •
edited
Loading

this closes #407

@panosatha panosatha requested a review from Santonia27 October 30, 2024 17:56
@panosatha panosatha linked an issue Oct 30, 2024 that may be closed by this pull request
spliting new composite areas uses max damage for indexing #407
Closed
4 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Santonia27
Santonia27 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@Santonia27 Santonia27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and tests are running fine! Thanks for simplifying

@Santonia27 Santonia27 merged commit ccbe70f into main Oct 31, 2024
5 checks passed
@Santonia27 Santonia27 deleted the 407-spliting-new-composite-areas-uses-max-damage-for-indexing branch October 31, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Santonia27 Santonia27 Santonia27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spliting new composite areas uses max damage for indexing
2 participants
@panosatha @Santonia27