if-statemnent unit conversion. read_geoms generalize for file type #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panosatha
reviewed
Nov 21, 2024
hydromt_fiat/fiat.py
Outdated
| @@ -1286,19 +1286,24 @@ def read_geoms(self): | |||
|
|
|||
| fns = glob.glob(Path(self.root, "geoms", "*.geojson").as_posix()) | |||
| if self.spatial_joins["aggregation_areas"]: | |||
| fns_aggregation = glob.glob(Path(self.root, "geoms", "aggregation_areas","*.geojson").as_posix()) | |||
| fns.append(fns_aggregation[0]) | |||
| fns_aggregation = glob.glob(Path(self.root, "geoms", "aggregation_areas/*").as_posix()) | |||
There was a problem hiding this comment.
will this now work if this is a shapefile wiht multiple files?
There was a problem hiding this comment.
a shapefile with multiple layers or multiple files in the folder?
I tested it with 2 files in the aggregation areas and that seemed to work
panosatha
requested changes
Nov 26, 2024
hydromt_fiat/fiat.py
Outdated
| fns = glob.glob(Path(self.root, "geoms", "*.geojson").as_posix()) | ||
| if self.spatial_joins["aggregation_areas"]: | ||
| fns_aggregation = glob.glob(Path(self.root, "geoms", "aggregation_areas","*.geojson").as_posix()) | ||
| fns.append(fns_aggregation[0]) | ||
| fns_aggregation = glob.glob(Path(self.root, "geoms", "aggregation_areas/*").as_posix()) |
There was a problem hiding this comment.
I dont understand why you are reading the location of the geometries from this pre-defined path, while these should be saved in the spatial_joins obejct. You could just read the paths from there right?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.