Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability method csv input #48

Merged
merged 13 commits into from
Mar 16, 2023
Merged

Conversation

luisrodriguezgalvez
Copy link
Contributor

No description provided.

luisrodriguezgalvez and others added 9 commits March 8, 2023 17:40
not working for me, cannot find
…ility.py. The test can be used to debug while writing the code.
start for manual input via user local csv, translate it into FIAT vulnerability format
very rigid but produces vulnerability output in the right format. Next steps would be allow for selection of which vulnerability curves to extract from the database, and give names to those. Also some changes to ini file that need updates for user inputs.
before vulnerability.py was already working by itself
decided to change and provide damage functions identifiers as csv from now on
by giving the input via csv following the template in the data folder
Copy link
Collaborator

@frederique-hub frederique-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but will change some things.

examples/fiat_flood.ini Show resolved Hide resolved
hydromt_fiat/vulnerability_test_file_output.csv Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can split the get_vulnerability_function into multiple functions.

@frederique-hub frederique-hub merged commit b74e94e into main Mar 16, 2023
@frederique-hub frederique-hub deleted the vulnerability_method_csv_input branch March 16, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants