Merge hazard update with main #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save fiat config
Update hazard
Update hazard
frederique-hub
approved these changes
May 3, 2023
| var, | ||
| chunks, | ||
| ) | ||
| ds.to_netcdf("C:/Users/fuentesm/CISNE/HydroMT_sprint_sessions/test_77.nc") |
There was a problem hiding this comment.
Could you remove the local path in the test and save the file with the function
hyfm.write()
There was a problem hiding this comment.
Great that you included both ways (programmatically and via the ini file) to test the hazard script!
There was a problem hiding this comment.
It looks good at first sight. Things to do still:
- Add docstrings
- Add type hinting
- Use underscores and only small letters for the function names (e.g. not checkInputs but check_inputs)
- Split the functions further into smaller functions, e.g. each check type could be it's own small function and the processing of event maps can be in a different function than the processing of RP flood maps.
There was a problem hiding this comment.
Please uncomment the code that you commented out to make it work in future commits, as now I have to resolve the issues in the merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.