Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows #197

Merged
merged 27 commits into from
Oct 5, 2023
Merged

Workflows #197

merged 27 commits into from
Oct 5, 2023

Conversation

dalmijn
Copy link
Collaborator

@dalmijn dalmijn commented Aug 11, 2023

This is still in progess and some stuff is up for discussion:

  • git dependencies vs stable release on conda (HydroMT)
  • Which dependencies in the pyproject.toml (Where to rely on HydroMT's dependencies)

@dalmijn dalmijn requested a review from savente93 October 4, 2023 13:39
Copy link

@savente93 savente93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, do note that I didnt' review any of the code/docs/config as they all seem linting things, and I don't have knowledge of them. Couple of small comments on the workflows, but aside from that it should be fine

Comment on lines +17 to +32
gh extension install actions/gh-actions-cache

REPO=${{ github.repository }}
BRANCH="refs/pull/${{ github.event.pull_request.number }}/merge"

echo "Fetching list of cache key"
cacheKeysForPR=$(gh actions-cache list -R $REPO -B $BRANCH -L 100 | cut -f 1 )

## Setting this to not fail the workflow while deleting cache keys.
set +e
echo "Deleting caches..."
for cacheKey in $cacheKeysForPR
do
gh actions-cache delete $cacheKey -R $REPO -B $BRANCH --confirm
done
echo "Done"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a PR open on core that refactors this and significantly improves testing speed so you might want to copy that over once it lands and is working well. For now this is fine though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait a bit (as you suggested) and create a seperate branch/ PR for it.

Comment on lines 73 to 74
- name: Check style
run: black --check .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be necessary here as that is tsted by the pre-commit/lining action

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Was rudimentary code.

Comment on lines 66 to 67
- name: Check style
run: black --check .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be necessary here as that is tsted by the pre-commit/lining action

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Comment on lines +4 to +7
push:
branches: [ main ]
pull_request:
branches: [ main ]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since these are equal to the triggers on test stable, they are going to always run in parallel. if you want test dev to only happen after stable, I think you need to remove this bit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test it. Thanks!

@dalmijn dalmijn merged commit 1efe95c into main Oct 5, 2023
3 of 4 checks passed
@JoostBuitink JoostBuitink deleted the workflows branch November 21, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants