Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update config from ini to yml #230

Merged
merged 4 commits into from
Jan 26, 2024
Merged

update config from ini to yml #230

merged 4 commits into from
Jan 26, 2024

Conversation

hboisgon
Copy link
Contributor

@hboisgon hboisgon commented Jan 19, 2024

Issue addressed

Fixes #207

Explanation

Update hydromt config files from ini to yaml. Also updated the tests and docs.

Checklist

  • Updated tests or added new tests
  • Branch is up to date with main
  • Tests & pre-commit hooks pass
  • Updated documentation if needed

@hboisgon hboisgon self-assigned this Jan 19, 2024
@hboisgon
Copy link
Contributor Author

I removed the _archive folder. There were still some old docs files on wflow build/update etc. I don't think we need to track this so I decided to remove rather than update the files.

@alimeshgi alimeshgi requested a review from dalmijn January 25, 2024 08:27
Copy link
Collaborator

@dalmijn dalmijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything checks out.

There seems to be a docs bug, but I made a separate issue for that #233

Also, the docstrings for the base 'Model' object methods 'update' and 'build' should be updated at some point.

@hboisgon hboisgon merged commit 47cfe4b into main Jan 26, 2024
6 checks passed
@hboisgon hboisgon deleted the yml_templates branch January 26, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config ini files should be translated to yml
2 participants