Notebook progressbar fix #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good to me! Perhaps it is good to add a comment to the pyproject.toml to briefly mention why we pinned this library (and/or link to #233)? In the case that we want to move to a newer version in the future, we can check whether this issue is sorted.
JoostBuitink
approved these changes
Feb 13, 2024
| @@ -70,6 +70,7 @@ doc = [ | |||
| examples = [ | |||
| "jupyterlab", | |||
| "cartopy", | |||
| "nbconvert==7.13.1", # Pin as of (02-2024); 7.14 onwards causes issues with the progressbar in example notebooks | |||
There was a problem hiding this comment.
Suggested change
| "nbconvert==7.13.1", # Pin as of (02-2024); 7.14 onwards causes issues with the progressbar in example notebooks | |
| "nbconvert==7.13.1", # Pin as of (02-2024); 7.14 onwards causes issues with the progressbar in example notebooks, see https://github.com/Deltares/hydromt_wflow/issues/233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #233
Explanation
Pin the nbconvert package.
Checklist
mainAdditional Notes (optional)
No