Issue #1188 Update the numba_celltree package #1189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1188
Description
In the numba_celltree package a change has been made that changes the behavior of the locate_points method.
In structured grids the behavior is that when a point lies on the left or bottom edge it is considered to be in the cell.
When the point lies on the right or top edge its considered outside of the cell
This kind of logic doesn't work for unstructured grids because the orientation of the cell can be anything.
However there are unit tests that do assume that this applies for unstructured grids as well. And those are the tests that are failing right now.
To solve this the bahavior has changed such that when a point lies on a cell edge its is considered to be in the cell. This also applies to structred grids.
This was
Checklist
Issue #nr
, e.g.Issue #737