Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1188 Update the numba_celltree package #1189

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

Manangka
Copy link
Collaborator

@Manangka Manangka commented Sep 5, 2024

Fixes #1188

Description

In the numba_celltree package a change has been made that changes the behavior of the locate_points method.

In structured grids the behavior is that when a point lies on the left or bottom edge it is considered to be in the cell.
When the point lies on the right or top edge its considered outside of the cell

This kind of logic doesn't work for unstructured grids because the orientation of the cell can be anything.
However there are unit tests that do assume that this applies for unstructured grids as well. And those are the tests that are failing right now.

To solve this the bahavior has changed such that when a point lies on a cell edge its is considered to be in the cell. This also applies to structred grids.

This was

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example

Copy link

sonarqubecloud bot commented Sep 5, 2024

Copy link
Contributor

@JoerivanEngelen JoerivanEngelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! This made me realize we have an edge case for well placement on a partition border, but that was already a problem for unstructured grids.

@JoerivanEngelen JoerivanEngelen added this pull request to the merge queue Sep 12, 2024
Merged via the queue into master with commit a325e2d Sep 12, 2024
6 checks passed
@JoerivanEngelen JoerivanEngelen deleted the issue_#1188_UpdateNumbaCelltree branch September 12, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update numba_celltree package
2 participants