Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install instructions update #6640

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

awdem
Copy link
Collaborator

@awdem awdem commented Mar 18, 2024

This PR:

  • Updates to install instructions in README.
  • Updates python version to 3.10.14. The previous version fails to install the dependencies without some workarounds.
  • Updates fake import scripts to make them work again.

@coveralls
Copy link

coveralls commented Mar 18, 2024

Coverage Status

coverage: 72.13%. remained the same
when pulling dff3e7d on awdem:install-instructions-update
into 3d3515f on DemocracyClub:master.

@awdem awdem self-assigned this Apr 30, 2024
@awdem awdem force-pushed the install-instructions-update branch from 3aa64c7 to dff3e7d Compare May 8, 2024 12:52
@awdem awdem force-pushed the install-instructions-update branch from dff3e7d to c005707 Compare May 9, 2024 10:01
@awdem awdem marked this pull request as ready for review May 15, 2024 09:45
Comment on lines -65 to -69
### Install testing python dependencies
```
pip install -r requirements/testing.txt
```

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this section is redundant.

@awdem awdem requested a review from GeoWill May 15, 2024 09:56
```
sudo -u postgres createdb polling_stations
sudo -u postgres createuser dc -P -s
sudo -u postgres createuser username -P -s
sudo -u postgres psql polling_stations
psql (9.3.6)
Type "help" for help.
Copy link
Collaborator Author

@awdem awdem Jul 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is about lines 112-117.

I find the description of this step unclear but wasn't sure how to update it to make it clearer. I assume it's telling you to update your local.py with the db user and password that you made when you created the database. But I don't know what I'm checking when I use \l in psql.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants