Module common #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mon to run directory
* Add utest change for hera * Add utest change for orion * Add utest change for dell p3
DeniseWorthen
added a commit
that referenced
this pull request
May 13, 2021
…bm_ic directory out of inputdata directory; use aws ec2 for CI test; auto-rt fixes (ufs-community#426) * Modifications to run tests on aws ec2 instances * Change layout numbers. Include all utests (#7) * Remove unnecessary sleep in build_test.yml and buidl_status_check.py * Increase sleep period in build_status_check.py to meet 60 requests/hr * Add sleep back to build_status.check.py * Minor changes. Change CI to develop branch * update diag_tables *add config variable for diag_table *set up diag_table templates for benchmarks (pre/v16) versions * fix diag table variable for v16 tests * add 35 v16 bmark frac test * add missing diag_table in bmark restart tests * Move bm_ic directory out of input-data directory * Replace sys exit with valueError in build_status_check.py * updates for v16 stability * remove un-used dz_min=6 parameter setting in bmark v16 tests * add psm_bc variable and set to value of 1 (default 0) for v16 tests * set dt_atmos=225 in v16 tests * updates for dated BM_IC directory * add INPUTDATA_ROOT_BMIC to rt.sh * remove BM_IC variable in cpld_bmark_run.IN and use explict path to specify IC sources for ATM,MOM6,CICE5 and WW3 (only for 35d test) * add variables in parm/input.benchmark_v16.nml.IN * set dddmp = 0.2 and FSICL to 0 in v16 bmark tests * modify v16 tests * keep FSICL at default value for now * reduce time for v16 wave test to 6hr * update RTPWD to 20130308; skip-ci * fix cpld_bmarkfrac_wave_v16 test * fix timestamps on files for comparison to baseline after switching to 6hour test length * remove restart file from WW3 comparison. Currently the restart file writes out only at hour 12. This is set in ww3_multi.inp. A change to allow writing a restart at hour 6 would require an update to the ww3 input data directory Co-authored-by: MinsukJi-NOAA <minsuk.ji@noaa.gov> Co-authored-by: Brian Curtis <brian.curtis@noaa.gov> Co-authored-by: climbfuji <dom.heinzeller@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Ths PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.
This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR
An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
are specified below.
If new or updated input data is required by this PR, it is clearly stated in the text of the PR.
Instructions: All subsequent sections of text should be filled in as appropriate.
The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsiblity to keep the PR up-to-date with the develop branch of ufs-weather-model.
Description
Provide a detailed description of what this PR does. What bug does it fix, or what feature does it add? Is a change of answers expected from this PR? Are any library updates included in this PR (modulefiles etc.)?
Issue(s) addressed
Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues must always be created before starting work on a PR branch!)
Testing
How were these changes tested? What compilers / HPCs was it tested with? Are the changes covered by regression tests? (If not, why? Do new tests need to be added?) Have regression tests and unit tests (utests) been run? On which platforms and with which compilers? (Note that unit tests can only be run on tier-1 platforms)
Dependencies
If testing this branch requires non-default branches in other repositories, list them. Those branches should have matching names (ideally).
Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs