Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read counts in Sample_composition_graph.html may still not be counted/added correctly #8

Closed
samnooij opened this issue Apr 2, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@samnooij
Copy link
Collaborator

samnooij commented Apr 2, 2019

This is an issue that I have tried to solve before, but it seems that the bug has not yet completely been fixed.

As it turns out, the Sample_composition_graph.html may show percentages > 100%. I found previously that this may be due to the sorting of samples (when the order becomes mixed, the numbers of one sample may be mixed with another, e.g. the number of bacteria in sample 1 are switched with the number of bacteria in sample 3). I tried to solve this by sorting the list of samples beforehand, but with more complex sample names (letter and number combinations: sort alphabetically or numerically?) the sorting may not always go right automatically.

Therefore, I propose to look into the sorting of samples with more complex names. Check if the problem is indeed there and fix it. Also include some checks to make sure the order is right (assert lines?).

If the problem is somewhere else, more bug-hunting is necessary.

@DennisSchmitz DennisSchmitz added the bug Something isn't working label Apr 2, 2019
@DennisSchmitz
Copy link
Owner

Any update on this @samnooij ?

@samnooij
Copy link
Collaborator Author

samnooij commented May 9, 2019

I was waiting if other people had problems with other data, but I have not seen any more problems with incorrect read counts. It seems the issue has been solved.

@DennisSchmitz
Copy link
Owner

Nice, then I`m closing it for now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants