Skip to content

Commit

Permalink
Disable play_filters_by_topic test (ros2#410)
Browse files Browse the repository at this point in the history
* disable play_filters_by_topic

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

* Add ticket to disabled test

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>

Co-authored-by: Tully Foote <tfoote@osrfoundation.org>

Co-authored-by: Tully Foote <tfoote@osrfoundation.org>
  • Loading branch information
mabelzhang and tfoote authored May 14, 2020
1 parent bfa6319 commit ced3c7e
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,8 @@ TEST_F(PlayEndToEndTestFixture, play_fails_gracefully_if_needed_coverter_plugin_
error_output, HasSubstr("Requested converter for format 'wrong_format' does not exist"));
}

#ifndef _WIN32
/*
todo(tfoote) Disabling failing test. Ticketed to follow up at: https://github.com/ros2/rosbag2/issues/408
TEST_F(PlayEndToEndTestFixture, play_filters_by_topic) {
// Due to a problem related to the subscriber, we play many (3) messages but make the subscriber
// node spin only until 2 have arrived. Hence the 2 as `launch_subscriber()` argument.
Expand Down Expand Up @@ -209,4 +210,4 @@ TEST_F(PlayEndToEndTestFixture, play_filters_by_topic) {
EXPECT_THAT(primitive_messages, SizeIs(Ge(0u)));
EXPECT_THAT(array_messages, SizeIs(Ge(0u)));
}
#endif
*/

0 comments on commit ced3c7e

Please sign in to comment.