Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: default Octicons to whitesmoke fill color #433

Merged
merged 1 commit into from
May 26, 2022

Conversation

DenverCoder1
Copy link
Owner

Description

For consistency with Simple Icons on shields.io, this makes Octicons have whitesmoke as the default fill color unless overridden by the logoColor parameter.

Logos that were previously black by default will now be whitesmoke color.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested endpoints locally

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 merged commit 41b424e into main May 26, 2022
@DenverCoder1 DenverCoder1 deleted the default-octicons-to-fill-whitesmoke branch May 26, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant