Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent broken PNG when logoColor is passed #977

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Sep 27, 2023

Summary

logoColor is NOT supported for PNG image icons, but this fixes a compatibility issue where images would appear broken when logoColor is passed.

As of now, logoColor still does nothing when a PNG image is loaded.

Fixes #969

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Screenshots

@DenverCoder1 DenverCoder1 temporarily deployed to custom-icon-fix-prevent-blcsaw September 27, 2023 07:54 Inactive
@DenverCoder1 DenverCoder1 merged commit 7be5d72 into main Sep 27, 2023
3 checks passed
@DenverCoder1 DenverCoder1 deleted the fix-Prevent-broken-png-when-logoColor-is-passed branch September 27, 2023 07:56
@Richmond574
Copy link

Power of God

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: custom badge stopped appearing
2 participants