Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icegray theme #270

Merged
merged 8 commits into from Jul 6, 2022
Merged

Add Icegray theme #270

merged 8 commits into from Jul 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2022

Description

Added a new icegray theme.

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)

How Has This Been Tested?

  • Tested locally with a valid username

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Without border:

image

With border:

image

@DenverCoder1
Copy link
Owner

Thanks for the contribution.

I'm thinking the contrast pretty low on this one making the text pretty difficult to read, maybe you could use darker colors for the text to make it more accessible?

This website can help check how accessible color combinations are https://webaim.org/resources/contrastchecker/?fcolor=C4C4C4&bcolor=FFFFFF

Also it seems the image you provided as a screenshot is different from how it currently appears on the site

image

@ghost
Copy link
Author

ghost commented Jul 6, 2022

Okay.
This is a screenshot from the demo site.
I'll fix it now.

@ghost
Copy link
Author

ghost commented Jul 6, 2022

I have updated the theme, documentation and PR.

@DenverCoder1 DenverCoder1 added enhancement New feature or request new theme adding a new theme labels Jul 6, 2022
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit 4467c29 into DenverCoder1:main Jul 6, 2022
@ghost ghost deleted the icegray-theme branch July 7, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new theme adding a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant